[patch #5893] integrated side-by-side textmode diff viewer
- From: Pavel Tsekov <INVALID NOREPLY gnu org>
- To: Pavel Tsekov <ptsekov gmx net>, Daniel Borca <dborca yahoo com>, mc-devel gnome org
- Subject: [patch #5893] integrated side-by-side textmode diff viewer
- Date: Fri, 04 May 2007 20:53:05 +0000
Follow-up Comment #5, patch #5893 (project mc):
Several points:
1) There is off-by-one error when calculating the size of
the `cmd' buffer in dff_execute ().
2) We use glib a lot in MC - you should do the same. Basically when there is
a glib counterpart of a given libc function you should use the glib one i.e.
malloc/free/strdup/sprintf/snprintf/etc.
I am still looking at the code so expect more feedback.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5893>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]