Re: [patch] Fix progress reporting for file move

Please, do not apply this patch for a while (day or two at most) ... I'll let you know. I am investigating something...

On Sun, 21 May 2006, Hampa Hug wrote:

Roland Illig wrote:

Hampa Hug wrote:
If a file is moved by copy/remove the progress bar is advanced twice. On
the other hand, if a file is moved by renaming the progress bar is never
updated. The attached patch fixes this.

Thanks for identifying and fixing this long-known bug. Before committing
the patch, I have one question left.

diff -ur mc-cvs/src/file.c mc-dev/src/file.c
--- mc-cvs/src/file.c	2006-04-25 05:05:17.000000000 +0200
+++ mc-dev/src/file.c	2006-05-03 07:09:36.000000000 +0200
@@ -1022,6 +1022,7 @@
     struct stat src_stats, dst_stats;
     int return_status = FILE_CONT;
+    int copy = 0;

This variable looks like it should be of type gboolean. I also find its
name too generic; maybe copy_done would be more appropriate?

I made a new patch with those two changes.


Pavel "The Prick" Tsekov

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]