Re: [patch] Fix progress reporting for file move

[Roland Illig <roland illig gmx de>]

Hampa Hug wrote:
> Hello
>
> If a file is moved by copy/remove the progress bar is advanced twice. On
> the other hand, if a file is moved by renaming the progress bar is never
> updated. The attached patch fixes this.

Thanks for identifying and fixing this long-known bug. Before committing 
the patch, I have one question left.

> diff -ur mc-cvs/src/file.c mc-dev/src/file.c
> --- mc-cvs/src/file.c	2006-04-25 05:05:17.000000000 +0200
> +++ mc-dev/src/file.c	2006-05-03 07:09:36.000000000 +0200
> @@ -1022,6 +1022,7 @@
>  {
>      struct stat src_stats, dst_stats;
>      int return_status = FILE_CONT;
> +    int copy = 0;

This variable looks like it should be of type gboolean. I also find its 
name too generic; maybe copy_done would be more appropriate?

Roland