Re: Depency on ld-linux.so.2(GLIBC_PRIVATE)

[Jindrich Novy <jnovy redhat com>]

Hi Leonard,

On Tue, 2005-11-15 at 21:53 +0100, Leonard den Ottolander wrote:
> Hi Pavel, list,
> 
> On Tue, 2005-11-15 at 14:22 -0500, Pavel Roskin wrote:
> > "nm mc" shows that the only symbol from GLIBC_PRIVATE is
> > __libc_enable_secure.  Search for __libc_enable_secure finds it in two
> > places:
> > 
> > intl/dcigettext.c - it's only used if that file is compiled as part of
> > libc, which is not the case.
> > 
> > slang/slcommon.c - this one uses __libc_enable_secure when glibc 2.x and
> > newer is used.  So, I guess it's upgrading S-Lang that introduced this
> > problem.
> 
> I've removed the dependency on __libc_enable_secure in slcommon.c.

Please correct the ChangeLog entry:

* slcommon.c (_pSLsecure_issetugid): Remove dependency on glibc private
function __libc_enable_secure().

__libc_enable_secure is not a function, but int.

The fix:
http://savannah.gnu.org/cgi-bin/viewcvs/mc/mc/slang/slcommon.c.diff?r1=1.1&r2=1.2
that is done is a bad hack that just confuses a reader of code, please consider
removing references to __libc_enable_secure completely.

Jindrich
-- 
Jindrich Novy <jnovy redhat com>, http://people.redhat.com/jnovy/
(o_                                                           _o)
//\      The worst evil in the world is refusal to think.     //\
V_/_                                                         _\_V