Re: [bug #13410] mc has no large file support

[Tomasz Kłoczko <kloczek rudy mif pg gda pl>]

On Wed, 15 Jun 2005, Jan ONDREJ wrote:

> Follow-up Comment #2, bug #13410 (project mc):
>
> Right, I am sorry.
>
> Fedora Core 4 has -D_FILE_OFFSET_BITS=64 parameter in spec file.

And remember: instead hardcoding this kind defines better use 
AC_SYS_LARGEFILE aclocal macro on autoconf level.

BTW autoconf:

$ ldd /usr/bin/mc
        libgmodule-2.0.so.0 => /usr/lib64/libgmodule-2.0.so.0 (0x00002aaaaaacd000)
        libdl.so.2 => /lib64/libdl.so.2 (0x000000329eb00000)
        libglib-2.0.so.0 => /usr/lib64/libglib-2.0.so.0 (0x00002aaaaabd0000)
        libext2fs.so.2 => /lib64/libext2fs.so.2 (0x00000032a0b00000)
        libcom_err.so.2 => /lib64/libcom_err.so.2 (0x00000032a1a00000)
        libgpm.so.1 => /usr/lib64/libgpm.so.1 (0x00000032a1800000)
        libslang-utf8.so.1 => /usr/lib64/libslang-utf8.so.1 (0x000000329f300000)
        libnsl.so.1 => /lib64/libnsl.so.1 (0x00000032a4700000)
        ^^^^^^ this
        libc.so.6 => /lib64/libc.so.6 (0x000000329e600000)
        /lib64/ld-linux-x86-64.so.2 (0x000000329e400000)
        libm.so.6 => /lib64/libm.so.6 (0x000000329e900000)

Above is on:
$ uname -s
Linux

and mc is linked with libnsl only because in autoconf is incorrect 
detection is linking with libnsl is neccessary (fix for this in 
attachement which contains also fix for detection is linking with 
libsocket is also neccessary).

kloczek
--
-----------------------------------------------------------
*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
-----------------------------------------------------------
Tomasz Kłoczko, sys adm @zie.pg.gda.pl|*e-mail: kloczek rudy mif pg gda pl*

--- mc-4.6.1a/configure.ac~	2005-06-15 21:15:48.000000000 +0200
+++ mc-4.6.1a/configure.ac	2005-06-15 21:15:48.000000000 +0200
@@ -294,31 +294,8 @@
 dnl Network related functions
 dnl
 
-AC_CHECK_LIB(nsl, t_accept)
-AC_CHECK_LIB(socket, socket)
-
-have_socket=no
-AC_CHECK_FUNCS(socket, have_socket=yes)
-if test $have_socket = no; then
-  # socket is not in the default libraries.  See if it's in some other.
-  for lib in bsd socket inet; do
-    AC_CHECK_LIB($lib, socket, [
-        LIBS="$LIBS -l$lib"
-	have_socket=yes
-	AC_DEFINE(HAVE_SOCKET)
-	break])
-  done
-fi
-
-have_gethostbyname=no
-AC_CHECK_FUNC(gethostbyname, [have_gethostbyname=yes])
-if test $have_gethostbyname = no; then
-  # gethostbyname is not in the default libraries.  See if it's in some other.
-  for lib in bsd socket inet; do
-    AC_CHECK_LIB([$lib], [gethostbyname],
-		 [LIBS="$LIBS -l$lib"; have_gethostbyname=yes; break])
-  done
-fi
+AC_SEARCH_LIBS(socket, socket)
+AC_SEARCH_LIBS(gethostbyname, nsl)
 
 dnl
 dnl Sequent wants getprocessstats
--- mc-4.6.1a/acinclude.m4~	2005-06-15 21:21:21.000000000 +0200
+++ mc-4.6.1a/acinclude.m4	2005-06-15 21:21:21.000000000 +0200
@@ -144,7 +144,6 @@
 
   if test "x$enable_netcode" != xno; then
     dnl FIXME: network checks should probably be in their own macro.
-    AC_CHECK_LIB(nsl, main)
     AC_SEARCH_LIBS(socket, [xnet bsd socket inet], [have_socket=yes])
     if test x$have_socket = xyes; then
       AC_SEARCH_LIBS(gethostbyname, [bsd socket inet netinet])