Observations on panel_operate() [was: Tilde expansion: When did it break?]



Hi,

I wrote:
> Good. While looking at panel_operate() you might want to verify that all
> char* are g_freed correctly.

temp2 == dest seems to be freed correctly. In case of handling multiple
entries temp2 gets g_freed. In case of a single entry dest gets g_freed
after the if (single_entry) else blocks.

In case of handling a single entry temp is assigned NULL instead of
being g_freed. Is that correct?

In case of multiple files temp is not g_freed (or even NULLed) either.

Also:
-    if (dest)
 	g_free (dest);

What about making char *source const?

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]