Re: Check patch for a separate color for hotkeys in red dialogs

[Leonard den Ottolander <leonard den ottolander nl>]

Hi Pavel,

On Wed, 2004-09-01 at 00:53, pavelsh wrote:
>   Check patch. It's make a separate color for hotkeys in red dialogs.

> -    { 0,             0, 0 }, /* unused */
> +    { "errorhot=",   0, 0 }, /* Error dialog normal/hot */

Ok. So you are using the unused entry for this. I am not sure if this is
entry is reserved for a reason (probably not as it doesn't state such a
warning). Also I wouldn't know if the new colour is better defined
*before* DEFAULT_COLOR_INDEX. Is there any funny arithmetic done with
these colour indexes? I wouldn't think so, as color.h states "For the
default color any unused index may be chosen". So I would say swap #30
and #31.

Also, you might want to add the colour index number in a comment, like
in most of the other lines. This would result in:

-    { 0,             0, 0 }, /* not usable (DEFAULT_COLOR_INDEX) *//* 30 */
-    { 0,             0, 0 }, /* unused */
+    { "errorhot=",   0, 0 }, /* Error dialog normal/hot *//* 30 */
+    { 0,             0, 0 }, /* not usable (DEFAULT_COLOR_INDEX) *//*
31 */

color.h would then change to:

-#define DEFAULT_COLOR_INDEX   30
+/* Error dialog color */
+#define ERROR_HOT_NORMAL   IF_COLOR (30, 0)
+#define DEFAULT_COLOR_INDEX   31
 #define DEFAULT_COLOR      IF_COLOR (DEFAULT_COLOR_INDEX, 0)
 
Maybe also bold? Not sure how that works out when the colour itself is
already defined with bold...

+#define ERROR_HOT_NORMAL   IF_COLOR (30, A_BOLD)

> +"errorhot=yellow,red";

Wouldn't black on red be nicer and more clear to see?:
+"errorhot=black,red";

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research