Re: extfs audio.in & hp48.in patch



Hello Roland,

On Mon, 2004-10-18 at 02:27, q# wrote:
>  hp48_cd()
>  {
>  (echo SET EXIT WARNING OFF;echo REMOTE HOST HOME
> -for HP48_DIR in `echo "$*" | tr '/' ' '`;do
> +for HP48_DIR in `echo "$1" | tr '/' ' '`;do

As I said: Please discuss before committing. In two steps this part has
now totally been ruined.

Maybe the quoting in this place was wrong. My mistake. But I didn't ask
you to commit, only to review. Now $* has changed from "$*" into "$1"
which is definitely *not* what is supposed to be.

Look folks. Many of us do not speak English very well. This will cause
misunderstandings that can be avoided if patches are not committed
blindly.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]