Re[2]: Couple of patches



Hello Andrew,

Friday, November 26, 2004, 4:21:45 PM, you wrote:

AVS> Hello,
>> 
>> On Thu, 25 Nov 2004, Pavel Tsekov wrote:
>> 
>> > Hello,
>> >
>> > I don't like the second hunk of direntry.c.patch.
>> >
>> > @@ -955,7 +957,7 @@ vfs_s_retrieve_file (struct vfs_class *m
>> >         if (got_interrupt ())
>> >             goto error_1;
>> >
>> > -       if (write (handle, buffer, n) < 0) {
>> > +       if (write (handle, buffer, n) != n) {
>> >             me->verrno = errno;
>> >             goto error_1;
>> >         }
>> >
>> > `errno' is not set if write () returns a positive value i.e.
>> > less bytes written than in the buffer.

AVS> Well, new incarnations with random me->verrno.


Committed. Thx.

-- 
Best regards,
 Pavel                            mailto:me pavelsh pp ru




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]