Re: Couple of patches

[Pavel Tsekov <ptsekov gmx net>]

Hello,

On Thu, 25 Nov 2004, Pavel Tsekov wrote:

> Hello,
>
> I don't like the second hunk of direntry.c.patch.
>
> @@ -955,7 +957,7 @@ vfs_s_retrieve_file (struct vfs_class *m
>         if (got_interrupt ())
>             goto error_1;
>
> -       if (write (handle, buffer, n) < 0) {
> +       if (write (handle, buffer, n) != n) {
>             me->verrno = errno;
>             goto error_1;
>         }
>
> `errno' is not set if write () returns a positive value i.e.
> less bytes written than in the buffer. Also it is ok to have
> write () with n = 0 - this should return 0.

Please, ignore the part about n = 0. Sorry.