Re: crash when entering some .tar files

["Andrew V. Samoilov" <andrew email zp ua>]

Hi, Pavel!
> 
> On Thu, 4 Mar 2004, wwp wrote:
> 
> > > > Yep, you will find the crashing .tar.bz2 (.tar would be enough, but I
> > > > crunched it for bandwidth purposes) here:
> > > > 	http://nanabozo.free.fr/tmp/mc/test.tar.bz2
> > >
> > > Well, patch attached.
> 
> Your message wasn't in the list.  What it going on with the list is a pure
> nightmare.  It gets hundreds of viruses a day, mostly with zip
> attachments, and the gnome.org admins are too busy with the next GNOME
> release to upgrade the server and set up filtering.
> 
> I had to use a script to kill all zip attachments from the moderation
> queue.  Maybe the script was buggy and killed your attachment.  Please
> resend it, and I'll apply it.  I'm sorry for inconvenience.

I am placing this patch inline:

vfs/ChangeLog:

	* direntry.c (vfs_s_resolve_symlink): Check vfs_s_fullpath()
	return value to avoid possible NULL dereference.

--- vfs/direntry.c	Fri Jan 30 01:12:01 2004
+++ vfs/direntry.c	Thu Mar  4 18:28:01 2004
@@ -217,9 +217,11 @@ vfs_s_resolve_symlink (struct vfs_class 
     /* make full path from relative */
     if (*linkname != PATH_SEP) {
 	char *fullpath = vfs_s_fullpath (me, entry->dir);
-	fullname = g_strconcat (fullpath, "/", linkname, NULL);
-	linkname = fullname;
-	g_free (fullpath);
+	if (fullpath) {
+	    fullname = g_strconcat (fullpath, "/", linkname, NULL);
+	    linkname = fullname;
+	    g_free (fullpath);
+	}
     }
 
     target =

-- 
Regards,
Andrew V. Samoilov.