Re: I'm away / viewer patch

Hello Roland,

On Fri, 2004-08-20 at 09:30, Roland Illig wrote:
> Concerning the patches for the viewer: I had left out the discussion 
> about the patch and have committed one myself. It's completely rewritten 
> and it works for me.

When you get back we might want to discuss a code of conduct. I don't
think it is a good idea that CVS committers commit their own code
without it being reviewed by others. If people start committing their
own code without having it reviewed things can become pretty messy very

Note that this criticism is not meant to be taken personally. It's just
that I believe the responsibilities of coding and committing should be
somewhat separated. New code should be reviewed by at least two other
people. Nothing wrong with coders having commit access, but to avoid
arbitrary decisions it would be good to keep the tasks separated, and
thus not commit own code (without review). Code might "work for you",
but that doesn't mean you've investigated all possible pitfalls. That's
why there's peer review.


mount -t life -o ro /dev/dna /genetic/research

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]