Re: [PATCH] 3 patches for MC-2003-09-15-04

[<tux centrum cz>]

...
> I don't think we should accept any new options for which there is no user
> interface.  There are too many of them already.  How many people actually
> edit the configuration files manually?
> 
> We probably need an additional dialog for advanced options.

Yes, It will be useful, maybe add some dialog that will accept some structure which will be an array like:

setting advanced_settings={
{"Time format - old",&timeformat,STRING},
{"Time format - recent",&timeformat_recent,STRING},
{"Torben FJ mode",&torben_fj_mode,BOOL},
{"Show Sort Mode indicator",&show_indicator,BOOL},
{"1 kilobyte is (1000/1024):",&one_kilobyte,INT),
...
};

If anyone else won't do that, I might do it after things calm a bit down in school .... in a week or two (semester just started)

Also, in future, it there would be too many options, this might allow for moving those options in tabs of some sort or whatever (multiple pages in advanced settings...) - just modify the dialog code and move the fields in two or more structures. Or make even the standard dialog this way .... 

And add the ":advanced settings" in Main menu -> settings

The dialog may be a bit tougher (like scrolling the dialog if too many options are shown on small terminal window, etc...) but not impossible.

Do you think this is a good idea?

I don't want to code anything that won't have chance of being accepted into MC at end ....

> 
> > sort_order.patch : change sort order by keyboard shortcuts, I
> >                    modified this patch for this mc version and
> >                    corrected one bug that was there
> >                    (indicator not repainting)
> 
> Same thing.  If the user interface is so hard to modify to add new
> options, then we should not ignore this problem.
> 
> However, I like the idea of using shortcuts compatible with Norton
> Commander.
> 
> > datefromat.patch : change datetime format, modified to apply to
> >                    current development version
> 
> Again, options without interface to set them.  Also, I don't think it's a
> good idea to override locale settings without serious reasons.

Well, this one does not modify locale, only the format in which MC displays things.
The reason I made this patch is that I hate having different time format for old (6+ monts cca) and new files, so having two different formats in one column is quite disorienting IMHO.

Martin Petricek