Re: Patches for mc-4.5.51

[Sean King <stking bway net>]

On Sat, Sep 20, 2003 at 09:35:07PM +0200, tux centrum cz wrote:
> > And yes, I sent patches addressing these issues, with no reply. Maybe
> > they are crappy, because I don't know the mc code much, but at least
> > "your patch sucks because of this and that" would be appreciated.
>
> I sent three patches too, but neither I saw them applied, neither
> I received email like "the patches sucks because ..." or at least
> "your patch sucks".

Say, you beat me to the punch -- I was going to say the exact same
thing! ;-)

...In key.c, we have 'xterm_key_defines' -- one group there is actually
commented as '/* rxvt keys with modifiers */'....

AFAICS, those sequences are defined (in init_key()) _only_ if
TERM=xterm* or TERM=iris-ansi* .

I suggested that

   || (!strncmp (term, "rxvt", 4))

be added (takes care of rxvt _and_ derivatives)

(or even,

   || (!strncmp (term, "rxvt", 4)) || (!strncmp (term, "Eterm", 5))

)

Not alone that nobody says, Great idea, thanks. (Maybe it _isn't_ a good
idea -- maybe I missed something.)

But nobody says: bad idea, because....

No one says: bad idea, and I'm not going to tell you why....

No one even says, Go jump in the lake....

Well, that's one way to run a project!

S.