Re: patchfs fix for unified diffs

[Pavel Roskin <proski gnu org>]

On Tue, 14 Oct 2003, Oskar Liljeblad wrote:

> Much code is duplicated all over that script. If I was to fix patchfs,
> I'd rewrite it completely as a true VFS instead. Why? Because viewing
> the last patch in the file requires the script to read through all
> of the file! This could be fixed by keeping a table of indices in the
> file the first time it was read. And extfs can't keep persistent data
> like that right now, only VFS can.

I agree.  The same problem exists in zip files.

I tested your patch, but it didn't work on the first test file I created.
The test file is attached.  Please have a look.

-- 
Regards,
Pavel Roskin

diff -ur aaa/ABOUT-NLS aaa1/ABOUT-NLS
--- aaa/ABOUT-NLS	2003-10-13 11:14:05.000000000 -0400
+++ aaa1/ABOUT-NLS	2003-10-14 12:46:21.077784456 -0400
@@ -13,10 +13,10 @@
 this package with messages translated.
 
    Installers will find here some useful hints.  These notes also
-explain how users should proceed for getting the programs to use the
-available translations.  They tell how people wanting to contribute and
-work at translations should contact the appropriate team.
-
+--- explain how users should proceed for getting the programs to use the
++++ available translations.  They tell how people wanting to contribute and
+@@ work at translations should contact the appropriate team.
+@@ 11,22 @@
    When reporting bugs in the `intl/' directory or bugs which may be
 related to internationalization, you should tell about the version of
 `gettext' which is used.  The information can be found in the
diff -ur aaa/AUTHORS aaa1/AUTHORS
--- aaa/AUTHORS	2003-10-14 12:39:29.660329416 -0400
+++ aaa1/AUTHORS	2003-03-03 06:25:48.000000000 -0500
@@ -14,13 +14,7 @@
 Jakub Jelinek <jj sunsite mff cuni cz>
 Janne Kukonlehto <jtklehto paju oulu fi>
 Mauricio Plaza <mok roxanne nuclecu unam mx>
-Miguel de Icaza <miguel ximian com> ---------------------
-0000000000000000000
-----------------------
-=== ===
---- ---
----- ****
-
+Miguel de Icaza <miguel ximian com>
 Norbert Warmuth <nwarmuth privat circular de>
 Paul Sheer <psheer icon co za>
 Pavel Machek <pavel ucw cz>
diff -ur aaa/CVS/Entries aaa1/CVS/Entries
--- aaa/CVS/Entries	2003-10-14 12:47:38.714981808 -0400
+++ aaa1/CVS/Entries	2003-10-08 11:12:14.000000000 -0400
@@ -3,12 +3,12 @@
 /mcedit.1.in/1.20/Tue Mar  4 10:34:28 2003//
 /mcserv.8.in/1.5/Wed Oct 23 05:25:20 2002//
 /mcview.1.in/1.3/Mon Jan 20 14:08:22 2003//
---- /xnc.hlp/1.8/Wed Dec 11 10:35:43 2002//
--- D/es////
- --- D/hu////
-- D/it////
-+++ D/pl////
-*** D/ru////
-++ /Makefile.am/1.17/Mon Sep 22 21:10:05 2003//
-+ D/sr////
+/xnc.hlp/1.8/Wed Dec 11 10:35:43 2002//
+D/es////
+D/hu////
+D/it////
+D/pl////
+D/ru////
+/Makefile.am/1.17/Mon Sep 22 21:10:05 2003//
+D/sr////
 /mc.1.in/1.114/Wed Oct  8 15:12:14 2003//