Re: mc 4.6.0 subshell fix for FreeBSD 5.x



hi, there!

On Mon, Jul 21, 2003 at 01:04:13AM -0400, Pavel Roskin wrote:

> > Attached patch fixes subshell support for FreeBSD 5.x which has grantpt(3).
> 
> What kind of problem do you have?  Does your patch work with FreeBSD 4.x?

Yes my patch works with FreeBSD 4.x.
FreeBSD 4.x does not have grantpt(3) so BSD version of
pty_open_master is compiled in from subshell.c.

FreeBSD 5.x has grantpt(3) and it is correctly detected in configure script
so HAVE_GRANTPT version of pty_open_master is compiled in.
On the other hand FreeBSD 5.x does not have getpt(), "/dev/ptc"
or "/dev/ptmx" but has posix_openpt(3) instead.

Of course, probing for posix_openpt(3) can be added to configure script
and its use in subshell.c can be surrounded by #if HAVE_POSIX_OPENT
instead of #ifdef __FreeBSD__.

/fjoe



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]