Re: Find file dialog in mc-4.6.0-pre3

[Arpi <arpi mplayerhq hu>]

Hi,

> > So i went and hunted down the bug :)
> 
> Thank you.  The code you found is completely broken.  However, your
> changes don't seem to make any difference for me.  Could you please send a
strange. it solved the problem completely for me, and it seems for others
too.

> patch that works for you?
..
> Maybe you could check the return value of select() - it returns the number
> of ready file descriptors.  We are not interested to know which file
> descriptor is ready.
good idea. i modified my fix that way:

--- key.c.orig  Sat Jan 25 15:24:09 2003
+++ key.c       Mon Jan 27 23:28:02 2003
@@ -1038,8 +1038,7 @@
 #endif
     timeout.tv_sec = 0;
     timeout.tv_usec = 0;
-    select (maxfdp, &select_set, 0, 0, &timeout);
-    return !FD_ISSET (0, &select_set);
+    return (select (maxfdp+1, &select_set, 0, 0, &timeout) <= 0);
 }



A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino