Re: Things to do before 4.6.0

[Pavel Roskin <proski gnu org>]

Hi, Andrew!

> > > > 4) Compressed tarballs produced by "tar cz" with older versions of GNU tar
> > > > (i.e. those with padding at the end) cannot be opened by pressing Enter
> > > > ("doesn't look like a tar archive")
> > > 
> > > Can someone provide an example tarball?
> > 
> > Attached (test.tgz)
> 
> This problem is in vfs/sfs.c/vfmake().
> Now it calls my_system and returns -1 if
> return code of my_system is not 0.
> 
> Well, gzip returns 2 for this test.tgz:

However, it returns 0 with the "-f" (force) flag:
> 
> test.tgz: decompression OK, trailing garbage ignored

Not with gzip-1.3.  In fact, debugging shows that mc never enters vfmake()
and never runs gzip.  The problem is with is_gunzipable() in src/util.c.  
It reads the uncompressed size at the end, and test.tgz has zeroes there.

-- 
Regards,
Pavel Roskin