Re: [PATCH] xterm titlebar

[Pavel Roskin <proski gnu org>]

Hello!

> > I believe that some versions of xterm may be incompatible.  Just
> > check init_xterm_support() in main.c:
> >
> > #if 0                           /* It works on xterm, but not on
> > rxvt */ printf (ESC_STR "]0;GNU Midnight Commander\7"); #endif
>
> That comment is probably outdated. Both the xterm_hintbar and
> xterm_titlebar features work in my rxvt 2.7.8. That's a
> development release, though.

I don't think that the code would be commented out if it was harmless on
older versions of rxvt.  I wish I could check the old rxvt, but I don't
have time.

Please keep in mind that testing usually takes more time than coding.  If
you don't check the dark corners, somebody will have to do it for you,
either now, or when somebody reports a problem a few months later.

> I tried what happens when the xterm_titlebar feature is used in an mc
> running in the linux console and it does nothing at all. Which I suppose
> is good. :) But maybe a check for getenv("DISPLAY") would be appropriate
> ?

Of course not.  The comment implies serious problems with rxvt, and you
cannot distinguish between rxvt and xterm by checking the DISPLAY
variable.

> Quoting is IMHO cumbersome in this case, a simpler and IMHO acceptable
> solution would be to remove all characters except some sane ones from
> the title.

Agreed.

-- 
Regards,
Pavel Roskin