Re: [PATCH] xterm titlebar

[Pavel Roskin <proski gnu org>]

Hello!

> Regarding the comments in the bug tracker, I also think that the patch
> is already very useful. Configurability would be nice, but it's not
> necessary, IMHO.

OK.

> The only problem I see is that when you switch to the background shell
> using CTRL+o, "cd" to some other directory, then the title is not
> updated. I don't how difficult would be to correct it ...

The same happens with the command prompt if the subshell is used.  But
unlike the command prompt, which requires interaction with the subshell,
displaying the titlebar can be done when the panels are redisplayed.
Perhaps make_panels_dirty() is not the right place to show the current
directory.

I'm concerned that the patch makes it impossible to disable the use of the
title bar on any xterm-like terminal.  xterm_hintbar is disabled by
default, so users can try it if they want and if they have a compatible
terminal.  I believe that some versions of xterm may be incompatible.
Just check init_xterm_support() in main.c:

#if 0                           /* It works on xterm, but not on rxvt */
        printf (ESC_STR "]0;GNU Midnight Commander\7");
#endif

Also entering directories with some unusual names, i.e. including the \7
character would cause mess on the screen.  Some quoting needs to be done
to avoid characters that can be interpreted by xterm.

-- 
Regards,
Pavel Roskin