Re: [PATCH]: copy/move/delete progress title

[Pavel Roskin <proski gnu org>]

Hello, Andrew!

>   This small patch adds title to the copy/move/delete progress window.

I recently spent a few hours (if not days) removing code like the one in
your patch.  By the way, one of your patches that you send me in private
didn't work well until this cleanup was done.

If you have more than one place when the title is drawn, you are going to
have problems down the road.  You cannot change spacing in a uniform way
(at least by a patch three lines long).  You cannot change the color of
all titles without actually changing color in more than one place.  In
fact, the color you are using is already different from all other dialogs!

If there is a reason why you cannot reuse the standard code that draws the
frames and the titles, please explain.  I'd rather see a bigger
improvement in the generic code (like introduction of DLG_COMPACT) if it's
needed, than a little change that breaks consistency and maintainability
of the code.

-- 
Regards,
Pavel Roskin