Re[4]: [PATCH] use proper value for the first argument of select ()

[Pavel Roskin <proski gnu org>]

Hello, Pavel!

> Ok - I see that I'm wrong now. Though my statement about speeding up
> select () is right, the patch is not correct. add_selects () is
> not used right in it, it can return 0 if the select channels are
> disabled - I'm attaching a fixed patch.

It still wasn't correct - you missed an FD_SET for gpm_fd.  Your patch
actually was killing gpm support.  Don't trust your eyes, trust F7 in the
editor and the "Find File" dialog :-)

While testing gpm support, another bug has been found and solved (I think
I even saw it "in the wild" long ago, when I was primarily using the
console).  If gpm dies, mc crashes.  The reason is that libgpm sets gpm_fd
to -1, which is used in FD_SET.  The patch has been committed separately.

By the way, it would be great if you start writing ChangeLog entries for
your patches (see GNU Coding Standards for the format).  Your patches are
very valuable, but they will be even more valuable is they require less
time to process.

Another side effect is that your name will be in ChangeLog.  As it stands
now, I cannot put my words under your name.

-- 
Regards,
Pavel Roskin