Re[4]: [PATCH] use proper value for the first argument of select ()



Hello Pavel,

Saturday, August 24, 2002, 8:36:54 PM, you wrote:

PT> Hello, Pavel!

PT> Saturday, August 24, 2002, 8:16:01 PM, you wrote:

>>> 1. Use the attached bad.tar.gz archive

PR>> Thanks.  If applied the patch for check_error_pipe().  Now I'd like to see 
PR>> a comment for the rest of the patch.

[snip]

PT> To answer your question how I've tested it - I haven't made a special
PT> testcase. I just ran MC and worked for a while - I haven't  seen
PT> anything broken, have you ?

Ok - I see that I'm wrong now. Though my statement about speeding up
select () is right, the patch is not correct. add_selects () is
not used right in it, it can return 0 if the select channels are
disabled - I'm attaching a fixed patch.

Attachment: mc-select-1st-arg-fixed.diff
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]