Re: Double // in codepages list error

On Sun, 12 Aug 2001, Walery Studennikov wrote:

> On Sat, Aug 11, 2001 at 11:12:19PM -0400, Pavel Roskin wrote:
> >
> > I understand that my criticism really should be directed at Walery, but
> > I'm asking everybody to clean up the code being modified instead of piling
> > one "quick fix" onto another.
> The patch is attached.
> Now we use concat_dir_and_file in charsets.c and on error we
> return filename that we failed to open.

It's ugly.  It's a nontrivial use of the return value that should
be at least commented in the code (ideally: avoided).

I don't understand what's wrong with moving the error messages to
charset.c from setup.c as I proposed.

Please use unified diff next time.

By the way, I've already fixed charset.c to use concat_dir_and_file().
The only remaining change is moving GUI where it belongs.

Pavel Roskin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]