RE: RelaxNG support for libxml++

["Stam, Michel [FINT]" <M Stam fugro nl>]

Hello Kjell,

I have submitted the bug as:
https://bugzilla.gnome.org/show_bug.cgi?id=737712

thank you for responding. The copyright notices have been updated as you
requested, and I did a very quick attempt at an example. Unfortunately I
cannot validate it on my development system here (the requirements for
mm-common don't add up with what I am running). Hope thats not too big a
problem.

Kind regards,

Michel Stam

Den 2014-09-30 12:20, Stam, Michel [FINT] skrev:
Dear list,

While upgrading the firmware in our products, I collected the patches we
made to open source software over the years, with the intention of
submitting these back upstream.

One such patch concerns libxml++, which was made by my colleague. This
patch adds support for rng validation (RelaxNG) to libxml++.

I have attached the patch to this email (as a git format-patch), because
my email client seems to corrupt patches every now and then.

Is it possible to apply this to the git tree?

Kind regards,

Michel Stam


Yes, it's probably possible to add RelaxNG validation to libxml++. Since
it's part of libxml2, it would fit well into libxml++. I haven't looked
closely into the patch yet. Three comments at this early stage.

1. It would be better to have the patch as an attachment to a bug in
Bugzilla, http://bugzilla.gnome.org, (Bindings - libxml++). Severity can
be "enhancement", which means it's not really a bug.

2. If we add RelaxNG validation, we should also add an example in the
examples directory.

3. Are the copyright notices in the new files correct, or just copied
from other files in libxml++? Is there a person named Ari Johnson,
claiming copyright to these files? If not, I recommend copying the
copyright notice from one of the newer files in libxml++, such as
libxml++/nodes/xincludestart.h, just adjusting the year.

You don't have to act on all my comments immediately. Once the patch is
in a bug, it can discussed and if needed modified there. I can do most
modifications myself if you like, but a small example program to test
the code would certainly be nice, even it it's not written to fit
directly into the examples directory.

Kjell