RE: [libxml++] xmlKeepBlanksDefault

[Murray Cumming Comneon com]

OK, looks good. One thing I forgot: Could you use the naming convention for
the member variables - I think we use a leading underscore.

Of course this is all theoretical until someone tests it with some libxml
code that sets this differently. But let's fix that bug if anyone ever
reports it. Well done.

Murray Cumming
murrayc usa net
www.murrayc.com 

> -----Original Message-----
> From: Christophe de VIENNE [mailto:cdevienne alphacent com] 
> Sent: Dienstag, 20. Mai 2003 11:51
> To: libxmlplusplus-general lists sourceforge net
> Subject: Re: [libxml++] xmlKeepBlanksDefault
> 
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Le Mardi 20 Mai 2003 11:02, Murray Cumming Comneon com a écrit :
> > Looks good. Minor points:
> > - If we are going to have the constant then we should use 
> it everywhere,
> > instead of something using true explicitly.
> > - In fact, this constant could go in the KeepBlanks class, 
> and could be the
> > default.
> 
> good idea. I was wondering where to put it...
> 
> > - I like each class to be in a file with the same name, so 
> this would be
> > keepblanks.[h|cc].
> 
> yes
> 
> >
> > I'm pleased that it seems to work without libxml changes.
> 
> me too.
> 
> 
> See attached modified patch.
> 
> I completely removed the keep_blanks context field setting in the 
> initialise_context method. I assume that KeepBlank is used 
> before calling it 
> (I added KeepBlanks were needed).
> I use KeepBlanks this way :
> 
> KeepBlanks k( KeepBlanks::Default );
> 
> I think it's much more clear what it does this way. Moreover 
> I still have the 
> idea, once it works correctly, to give the possibility to 
> change the default 
> value on a per-parser and per-document basis. We have to 
> discuss this before 
> anyway (I suspect a long thread about this :-).
> 
> 
> Cheers,
> 
> Christophe
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.1 (GNU/Linux)
> 
> iD8DBQE+yfqHB+sU3TyOQjARAnoXAKCa5+2yz2a+IBOIH4LzQbAY+42qTQCfRTpw
> Kqd5U+7Cdbv/Do16Ca/FXs0=
> =HGsW
> -----END PGP SIGNATURE-----
>