RE: [libxml++] xmlKeepBlanksDefault

[Murray Cumming Comneon com]

Looks good. Minor points:
- If we are going to have the constant then we should use it everywhere,
instead of something using true explicitly.
- In fact, this constant could go in the KeepBlanks class, and could be the
default.
- I like each class to be in a file with the same name, so this would be
keepblanks.[h|cc].

I'm pleased that it seems to work without libxml changes.

Murray Cumming
murrayc usa net
www.murrayc.com 

> -----Original Message-----
> From: Christophe de VIENNE [mailto:cdevienne alphacent com] 
> Sent: Dienstag, 20. Mai 2003 10:55
> To: libxmlplusplus-general lists sourceforge net
> Subject: [libxml++] xmlKeepBlanksDefault
> 
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> Here is a patch to fix the xmlKeepBlanksDefault problem.
> I'd like comments before commiting it.
> 
> The dom_read_write example is behaving correctly with this patch.
> 
> Cheers,
> 
> Christophe
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.1 (GNU/Linux)
> 
> iD8DBQE+ye10B+sU3TyOQjARAql7AJ4woMNi477sJzjlQUwpd6svH/jARgCgkOz2
> V+sfWDjq9xs7Pl560VMDqEA=
> =jeEz
> -----END PGP SIGNATURE-----
>