Re: [libxml++] Patch for Node::find( nonexistent_xpath ) to return empty NodeSe t

[Christophe de VIENNE <cdevienne alphacent com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Mardi 6 Mai 2003 19:17, andy glew amd com a écrit :
> Patch attached.  Unidiff -u 20, prepared from cvs diff in my local
> repository.  My version of patch doesn't seem to be
> able to figure out file to patch automatically, but there's only
> one... libxml++/nodes/nodes.c
>
> I chose the fix that most quickly solved my problem:
> having libxml++ return an empty NodeSet when libxml2 does.
> I did NOT choose to throw an exception as Murray suggested,
> since (1) that would make my code using it more complex,
> and (2) it is onconsistent with libxml2.
>

The patch looks good to me. I'll include when I'm home this evening.

Next time please patch the ChangeLog too and use the patch manager on 
sourceforge.

> Long term the right way is to do what Stefan Seefeld suggested,
> returning an XPathResult that unifies NodeSets and other
> xpath return types.

yes

Thanks,

Christophe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+t/MtB+sU3TyOQjARAqK5AJ9+2gXFIVoRsttmZEBCZVZUYUPllgCdHWT6
W4lyNgpSoL114iWOCiz1knY=
=Vv9r
-----END PGP SIGNATURE-----