[libxml++] Re: Fix to libxml++ [node.cpp]

[Christophe de Vienne <cdevienne alphacent com>]

Le Mardi 18 Mars 2003 21:02, vous avez écrit :
> Hello Christophe,

Hi,

> I have gotten libxml++ 0.22.0 and made a few changes (see attached):
>
> 1. Created a Microsoft Developer Studio project/workspace ("win32" subdir)
> Note that DevStudio did not like the "+"'s, so I named the project
> "libxmlpp".

A patch with mvsc++ project/workspace files is being included in the CVS

>
> 2. Changed all ".cc" files in the "libxml++" subtree to ".cpp" (did not
> change examples)
> It is possible to get DevStudio to recognize ".cc" files as C++ code, but
> it does not
> do so by default. I think ".cpp" is a fairly universal C++ extension
> nowadays.
>

Well, we already spoke about this on the mailing list. We will probably not 
change the file extension (unless we have _huge_ demand for that).

> 3. Fixed a null-pointer problem in "node.cpp" which was causing an
> unpleasant crash
> I notice that other pointers are not checked for null either. I could not
> tell which might
> be dangerous, so I only concerned myself with the one causing the crash. I
> think you
> can reproduce crash by removing all "linkend"'s from "example.xml".

Could you provide us a separate patch for this problem ? And putting it in the 
patch manager would be even better 
(http://sourceforge.net/tracker/?atid=312999&group_id=12999&func=browse). 
Thanks.
If you don't know how to create a path, have a look to :
http://gtkmm.sourceforge.net/bugs.shtml

>
>
> I would be happy to add DevStudio projects for the examples, but was not
> sure if you
> would accept these changes.
> Let me know if I should go about making changes
> like
> this differently (I have never done this before).

Thanks very much for your proposition, but as I said it's being done...

>
> BTW, I like the class library
> Thanks!
> Chris

Thanks.

For further discussion (I'm sure you'll bring us usefull contribution(s)), 
please use the mailing list (http://sourceforge.net/mail/?group_id=12999).


Best regards,

Christophe