Re: libsoup leads to crashes

[Steffen Kuche <kuche subshell com>]

Hallo Dan,

it maybe an eclipse bug, but the patch would be an improvement for libsoup, wouldn't it?
To check whether a point is set or not, is not a bad idea, or ? 

At least it would do no harm.

There are many eclipse installations < 4.3 out there and it would be great if it could be fixed in libsoup, 
even if the originator is eclipse.

Thank you!

Kind regards,

Steffen



--
subshell GmbH
Steffen Kuche
Hongkongstraße 5               t +49.40.431 362-14
20457 Hamburg                  f +49.40.431 362-29
http://www.subshell.com        kuche subshell com
Geschäftsführung: Jan Boddin & Tom Quellenberg
Handelsregister: Amtsgericht Hamburg, HRB 74783

----- Ursprüngliche Mail -----
Von: "Dan Winship" <danw gnome org>
An: "Steffen Kuche" <kuche subshell com>, libsoup-list gnome org
Gesendet: Dienstag, 16. Dezember 2014 14:31:31
Betreff: Re: libsoup leads to crashes

This is not a libsoup bug, it's an eclipse bug, which was fixed in
eclipse 4.3. (https://bugs.eclipse.org/bugs/show_bug.cgi?id=404776)

-- Dan

On 12/16/2014 07:00 AM, Steffen Kuche wrote:
> Hello,
>
> we at subshell.com build an application based on the eclipse rcp, with embedded browsers. We encounter 
> crashes of our application on ubuntu because of libsoup.
> If I could get write permissions to your git repository at git://git.gnome.org/libsoup, I will fix the bug.
>
> You find the corresponding error report attached.
>
> Here is the relevant patch (in soup-session-feature.c):
>
> void
>  soup_session_feature_attach (SoupSessionFeature *feature,
>                   SoupSession        *session)
>  {
> +    if (!feature)
> +        return;
> +
>      SOUP_SESSION_FEATURE_GET_CLASS (feature)->attach (feature, session);
>  }
>   
> void
>  soup_session_feature_detach (SoupSessionFeature *feature,
>                   SoupSession        *session)
>  {
> +   if (!feature)
> +       return;
> +
>      SOUP_SESSION_FEATURE_GET_CLASS (feature)->detach (feature, session);
>  }
>
>
> There are some tests which had to be adapted after applying the above patch.
>
> It would be great, if we could solve the bug in libsoup!
>
> Thank you!
>
> Kind regards,
>
> Steffen Kuche
>
> --
> subshell GmbH
> Steffen Kuche
> Hongkongstraße 5               t +49.40.431 362-14
> 20457 Hamburg                  f +49.40.431 362-29
> http://www.subshell.com        kuche subshell com
> Geschäftsführung: Jan Boddin & Tom Quellenberg
> Handelsregister: Amtsgericht Hamburg, HRB 74783
>
>
>
> _______________________________________________
> libsoup-list mailing list
> libsoup-list gnome org
> https://mail.gnome.org/mailman/listinfo/libsoup-list