On 22/08/13 21:40, Dan Winship wrote:
On 08/22/2013 12:00 PM, Joseph Artsimovich wrote:Hi, I implemented systemd socket activation mechanism for libsoup. The idea behind systemd socket activation is to launch a server on demand, when a client connects to it. Unlike with inetd, it doesn't mean a separate instance of a server is launched for each client connection. Instead, systemd passes a listening socket to the server process. The patch is attached. Please review.I think the idea is fine, but it would be better to just make it possible to create a SoupServer by passing in a socket fd, and then all the systemd-specific stuff can happen outside of libsoup.
OK. Take a look at the updated patch then. Taking GSocket* proved to be more convenient then taking a file descriptor. Glib provides g_socket_new_from_fd(), so that's functionally equivalent. -- Joseph Artsimovich Software Engineer at YouView TV Ltd
Attachment:
0001-Make-it-possible-to-provide-a-custom-listening-socke.patch
Description: Text document