Re: invalid read size 1 under valgrind

[Austin Foxley <austinf gmail com>]

On Wed, Feb 22, 2012 at 10:24 AM, Dan Winship <danw gnome org> wrote:
> On 02/22/2012 12:57 PM, Austin Foxley wrote:
>> I am developing a upnp client using gupnp (which uses libsoup) and ran
>> into this apparent off-by-one when running under valgrind. This is
>> with libsoup in fedora 16 (libsoup-2.36.1-2.fc16.x86_64). I took a
>> look at the source but it wasn't obvious to me where the problem was.
>> Hopefully someone more familiar with this code can make sense of this
>> one.
>>
>> ==21821== Invalid read of size 1
>> ==21821==    at 0x3BB5E37A29: read_metadata (soup-message-io.c:325)
>
> Yeah, the code is wrong there, it needs to be checking
> io->read_meta_buf->len...
>
> Is this causing a bug in your server, or just valgrind output?
>

I don't think it's causing a problem currently.

-Austin