Re: [PATCH] soup-message-io: protect unpause_source by mutex

[Dan Winship <danw gnome org>]

On 01/21/2010 03:37 AM, Andrew W. Nosenko wrote:
> On Wed, Jan 13, 2010 at 13:45, Andrew W. Nosenko
> <andrew w nosenko gmail com> wrote:
>> soup-message-io: protect unpause_source by mutex
>>
>> Otherwise the the multithreaded program, which pauses message in the
>> one (server) thread and unpauses it in the another (worker) thread may
>> experience a crash under high workload (and in my case experienced it
>> indeed).
> 
> Ping?

(So first off, you should file patches in bugzilla, not on the mailing
list.)

Anyway, yes I saw the message. I haven't look at it in detail yet. Note
that the docs state that only SoupSessionSync is thread-safe, and since
soup_session_pause_message() only works with SoupSessionAsync, this
probably means you're doing something which is known to not work, and
even after fixing this there will probably be other problems too,
because none of the async code paths have been tested much for threadsafety.

-- Dan