Re: [libcroco-list] Generic cascading in libcroco

[Robert Staudinger <robert staudinger gmail com>]

On Thu, Feb 19, 2009 at 4:55 PM, Dodji Seketeli <dodji gnome org> wrote:
> Hello,
>
> Robert Staudinger a écrit :
>
> [...]
>
>> I've finally gotten around to add a generic interface to the libcroco
>> selection engine. Pretty much just exchanging libxml calls to
>> invocations on an vtable provided by the API consumer.
>>
>> On top of that I reinstated the libxml-based API and made sure the
>> tests (the selection engine is only used by test5) work as before.
>
> Sounds great ! Thanks for that.
>
>> Are you inkscapers still interested in eventually using upstream
>> libcroco? Your internal copy seems to have deviated pretty much from
>> upstream, it would be good if we could at least exchange fixes, things
>> were not quite obvious looking at the raw rdiff. We (Thomas Wood +
>> yours truly) actually tried to extract just the selection engine
>> patch(es) from your svn repository, but it proved quite hard to make
>> any sense of it.
>
> I don't know for inkscape, but I'll happily review the patch of that
> feature if you for instance submit it to the libcroco bugzilla.
>
>
>> My branch is at
>> http://bzr-playground.gnome.org/~robsta/libccss-selection-engine/
>> but will go to trunk within the next few days, as the tests already
>> work as they should.
>
> Could, would it be possible to extract a patch from that and slam it to
> bugzilla so that I can have a chance to review it ? I don't intend to
> nitpick, do not worry :) It's just to add some more eyeballs to the game :)

http://bugzilla.gnome.org/show_bug.cgi?id=572454

- R