Re: [libcroco-list] Typo in cr_tknzr_get_next_token

[Bjoern Hoehrmann <derhoermi gmx net>]

* Bjoern Hoehrmann wrote:
>  There is a bug in the latest SVN version in cr_tknzr_get_next_token
>which has:
>
>  ...
>  next_bytes[0] = BYTE (input, 1, NULL);
>  next_bytes[1] = BYTE (input, 2, NULL);
>  next_bytes[2] = BYTE (input, 3, NULL);
>  next_bytes[3] = BYTE (input, 3, NULL);
>  ...
>
>The last 3 should be a 4.

And there is more wrong with that, these bytes are compared case-sen-
sitively even though unit identifiers are case-insensitive, so for e.g.

  font-size: 10PX;

this will fall apart (libcroco will not invoke the property handler
after it encountered this; the 3 vs 4 bug above triggers the same be-
havior for e.g. foo:1grad;).
-- 
Björn Höhrmann · mailto:bjoern hoehrmann de · http://bjoern.hoehrmann.de
Weinh. Str. 22 · Telefon: +49(0)621/4309674 · http://www.bjoernsworld.de
68309 Mannheim · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/