Re: Tweaks to held-key activation

[David Schneider <dnschneid gmail com>]

Pressing another key cancels the held state.  It would do very bad things
if you hit another key without letting go of the held one.

---------- Fri, 8 Apr 2011 01:02:41 -0700 ----------
David Schneider <dnschneid gmail com> wrote:

> As mentioned in a completely unrelated bug report, the hold-key activation
> of actions is sort of useless as is.
> I've found that when using it, the end result is that you accidentally spew
> whatever key you were holding into the launched app.  Not helpful.
> 
> This patch changes it so that the action activates upon release (if you
> held it long enough).  For visual feedback, when you've held it long enough
> the current matchview turns to the active color.
> 
> Maybe it's more useful now; but maybe not.

>From 32929830ea095a80c465970a907814fd8fc51760 Mon Sep 17 00:00:00 2001
From: David Schneider <dnschneid gmail com>
Date: Fri, 8 Apr 2011 02:02:41 -0700
Subject: [PATCH] Reset key held state on different button press.

---
 kupfer/ui/browser.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kupfer/ui/browser.py b/kupfer/ui/browser.py
index 2ac4651..cf8ffc5 100644
--- a/kupfer/ui/browser.py
+++ b/kupfer/ui/browser.py
@@ -1165,6 +1165,9 @@ class Interface (gobject.GObject):
 		else:
 			self._key_press_time = curtime
 			self._key_pressed = keyv
+			if self._key_held:
+				self._key_held_feedback(False)
+				self._key_held = False
 
 
 		if keyv not in self.keys_sensible:
-- 
1.7.1