Re: [PATCH] + chromium bookmarks plugin

From: Ulrik Sverdrup <ulrik sverdrup gmail com>
To: Kupfer list <kupfer-list gnome org>
Subject: Re: [PATCH] + chromium bookmarks plugin
Date: Wed, 14 Oct 2009 17:54:44 +0200

On Wed, Oct 14, 2009 at 04:30:34PM +0200, Francesco Marella wrote:
> + chromium bookmarks plugin
> --
> Francesco Marella <francesco marella gmail com>

Hi Francesco,

Thank you for this contribution. I'm going to comment the patch inline
below on some very minor things, but first -- chromium_support.py

It looks like chromium_support.py parses JSON by regex. This is
seriously Eww, doesn't matter if Gnome-Do tested it for us, it will have
parsing bugs and it is wrong, when we have better tools for this.

Follow-Ups:
- Re: [PATCH] + chromium bookmarks plugin
  - From: Francesco Marella

References:
- [PATCH] + chromium bookmarks plugin
  - From: Francesco Marella

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]