Re: Gnome Terminal session

[Ulrik Sverdrup <ulrik sverdrup gmail com>]

2009/11/22 Chmouel Boudjnah <chmouel chmouel com>:
> Hi Ulrik,
>
> I made a simple Gnome Terminal session plugin for kupfer :
>
> http://is.gd/50H4X
>
> I am still fighting with tabs and spaces and I am sure you may have
> comment about it like gconf change monitoring (but since it's very
> rare to change gnome profile session it's not very worthy to code it).
>
> Let me know wdyt.

Hi this looks fine already. Simple is great, I love it when kupfer
plugins come together in less than 50 lines of code. I think you are
absolutely right that no change notification should be necessary.

Some suggestions to make it ready for inclusion:

I think it should be a source, not a text source, else it's a bit
confusing and it won't be the content of the terminal application then
either.

Gconf is not a dependency of kupfer, so this import line should be
*below* the plugin information, right below where you define
__author__. This is a Kupfer peculiarity -- but long story short it
will then fail graciously for users that don't have gconf installed.

The plugin/python module is it's own namespace so you can drop the
GnomeTerminal prefix to the names to make them a bit more relaxed
length.

Description can be in sentence case -> "Launch Gnome Terminal
sessions". And The source's name can be the same as the plugin's name.

To not repeat the object and action icons, the action can have the
following icon:

(from kupfer import icons)

    def get_gicon(self):
        return icons.ComposedIcon("gtk-execute", "terminal")

thank you for this!
ulrik