[jokosher-devel] [PATCH] misc menu-items/labels cleaned up



Hello, this is my first patch submission to Jokosher. This is a very minimal patch that just fixes some menu-items to have alt-underline functionality, changes a couple tooltips to be consistent (the menu-item for "Add Instrument" and the button had different tooltips, seems like it should be consistent), and changed appropriate menu-item labels to use the "..." where needed.  Also, just added a couple tooltips for the Zoom buttons. Just a *minor* bit of polish.

(patched against 1352)
Index: Jokosher/Jokosher.glade
===================================================================
--- Jokosher/Jokosher.glade	(revision 1352)
+++ Jokosher/Jokosher.glade	(working copy)
@@ -293,7 +293,7 @@
 		    <widget class="GtkImageMenuItem" id="add_instrument1">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Add an instrument to the project</property>
-		      <property name="label" translatable="yes">_Add Instrument</property>
+		      <property name="label" translatable="yes">_Add Instrument...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_AddInstrument_clicked"/>
 
@@ -315,7 +315,7 @@
 		    <widget class="GtkImageMenuItem" id="add_audio_file_project_menu">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Add an audio file to the project</property>
-		      <property name="label" translatable="yes">Add Audio File</property>
+		      <property name="label" translatable="yes">Add Audio _File...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_project_add_audio" last_modification_time="Tue, 26 Dec 2006 18:58:33 GMT"/>
 
@@ -337,7 +337,7 @@
 		    <widget class="GtkImageMenuItem" id="instrument_connections1">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Manage instrument recording inputs</property>
-		      <property name="label" translatable="yes">_Recording Inputs</property>
+		      <property name="label" translatable="yes">_Recording Inputs...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_instrumentconnections_activate"/>
 
@@ -410,7 +410,7 @@
 		    <widget class="GtkImageMenuItem" id="add_audio_file_instrument_menu">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Add an audio file to the selected instrument</property>
-		      <property name="label" translatable="yes">Add Audio File</property>
+		      <property name="label" translatable="yes">Add Audio _File...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_instrMenu_add_audio" last_modification_time="Tue, 26 Dec 2006 18:58:33 GMT"/>
 		    </widget>
@@ -420,7 +420,7 @@
 		    <widget class="GtkMenuItem" id="change_instrument_type">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Change type of the selected instrument</property>
-		      <property name="label" translatable="yes">Change Instrument Type</property>
+		      <property name="label" translatable="yes">_Change Instrument Type...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_change_instr_type_activate" last_modification_time="Tue, 26 Dec 2006 18:59:24 GMT"/>
 		    </widget>
@@ -430,7 +430,7 @@
 		    <widget class="GtkImageMenuItem" id="remove_selected_instrument">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Remove the selected instrument</property>
-		      <property name="label" translatable="yes">Remove Selected Instrument</property>
+		      <property name="label" translatable="yes">_Remove Selected Instrument</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_remove_instr_activate" last_modification_time="Tue, 26 Dec 2006 18:59:48 GMT"/>
 
@@ -471,7 +471,7 @@
 		    <widget class="GtkMenuItem" id="manage_extensions1">
 		      <property name="visible">True</property>
 		      <property name="tooltip" translatable="yes">Open the extension manager</property>
-		      <property name="label" translatable="yes">_Manage Extensions</property>
+		      <property name="label" translatable="yes">_Manage Extensions...</property>
 		      <property name="use_underline">True</property>
 		      <signal name="activate" handler="on_ExtensionManager_activate"/>
 		    </widget>
@@ -592,7 +592,7 @@
 	      <child>
 		<widget class="GtkToolButton" id="AddInstrument">
 		  <property name="visible">True</property>
-		  <property name="tooltip" translatable="yes">Add a new instrument</property>
+		  <property name="tooltip" translatable="yes">Add an instrument to the project</property>
 		  <property name="label">Add Instrument</property>
 		  <property name="use_underline">True</property>
 		  <property name="stock_id">gtk-add</property>
@@ -614,6 +614,7 @@
 	      <child>
 		<widget class="GtkToolButton" id="addAudioFileButton">
 		  <property name="visible">True</property>
+                  <property name="tooltip" translatable="yes">Add an audio file to the project</property>
 		  <property name="label" translatable="yes">Add Audio File</property>
 		  <property name="use_underline">True</property>
 		  <property name="stock_id">gtk-open</property>
@@ -726,7 +727,7 @@
 	      <child>
 		<widget class="GtkToggleToolButton" id="Record">
 		  <property name="visible">True</property>
-		  <property name="tooltip" translatable="yes">Arm an instrument, then click here to begin recording</property>
+		  <property name="tooltip" translatable="yes">Arm an instrument then click here to begin recording</property>
 		  <property name="stock_id">gtk-media-record</property>
 		  <property name="visible_horizontal">True</property>
 		  <property name="visible_vertical">True</property>
Index: Jokosher/RecordingView.py
===================================================================
--- Jokosher/RecordingView.py	(revision 1352)
+++ Jokosher/RecordingView.py	(working copy)
@@ -121,12 +121,14 @@
 			inimg = gtk.image_new_from_stock(gtk.STOCK_ZOOM_IN, gtk.ICON_SIZE_BUTTON)
 			inbutton.set_image(inimg)
 			inbutton.set_relief(gtk.RELIEF_NONE)
+			self.zoomtip.set_tip(inbutton, gettext.gettext("Zoom in timeline"), None)
 			inbutton.connect("clicked", self.OnZoomIn)
 			
 			outbutton = gtk.Button()
 			outimg = gtk.image_new_from_stock(gtk.STOCK_ZOOM_OUT, gtk.ICON_SIZE_BUTTON)
 			outbutton.set_image(outimg)
 			outbutton.set_relief(gtk.RELIEF_NONE)
+			self.zoomtip.set_tip(outbutton, gettext.gettext("Zoom out timeline"), None)
 			outbutton.connect("clicked", self.OnZoomOut)
 
 			self.hb.pack_start( outbutton, False, False)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]