[jokosher-devel] [Patch] Fixed a future bug that would occur when gst goes 0.11.0+
- From: "David Corrales" <corrales david gmail com>
- To: jokosher-devel-list <jokosher-devel-list gnome org>
- Subject: [jokosher-devel] [Patch] Fixed a future bug that would occur when gst goes 0.11.0+
- Date: Sat, 25 Nov 2006 15:04:54 -0600
The current comparison uses an OR to match versions prior to 0.10.9. This is good as long as the middle version doesn't jump to 0.11.0 or greater, as it would fail the check while being a sane version.
I also changed a variable name to improve code readability.
Index: /home/david/Projects/Jokosher/Jokosher/JokosherApp.py
===================================================================
--- /home/david/Projects/Jokosher/Jokosher/JokosherApp.py (revision 964)
+++ /home/david/Projects/Jokosher/Jokosher/JokosherApp.py (working copy)
@@ -1101,9 +1101,10 @@
def CheckGstreamerVersions(self):
#Check for CVS versions of Gstreamer and gnonlin
message = ""
- v = gst.version()
- if (v[1] < 10) or (v[2] < 9):
- message += _("You must have Gstreamer version 0.10.9 or higher.\n")
+ gstVersion = gst.version()
+ if (gstVersion[1] < 10):
+ if (gstVersion[2] < 9):
+ message += _("You must have Gstreamer version 0.10.9 or higher.\n")
gnl = gst.registry_get_default().find_plugin("gnonlin")
if gnl:
ignored, gnlMajor, gnlMinor = gnl.get_version().split(".", 2)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]