Re: Serialization review from August

[Daniel Espinosa <esodan gmail com>]

I agree you merge with modifications. At the end tests must pass, if not I could fix them but directly on master.

El nov 16, 2013 9:38 a.m., "Richard Schwarting" <richard schwarting ca> escribió:

I'm happy with a lot of it.

Would you prefer if I just give you feedback and let you respond to it, or

do you mind if I start merging things with modifications (API names, visibility, comments) and perhaps changing to a new branch, and then you can object or agree to things?
(I feel like that second option may be faster, and save you from doing extra work)?

On Sat, Nov 16, 2013 at 9:24 AM, Richard Schwarting <richard schwarting ca> wrote:

Doing so now.  Thanks.

On Sat, Nov 16, 2013 at 12:23 AM, Daniel Espinosa <esodan gmail com> wrote:

I'll answer your questions if you want but really prefer you review again because changes are a lot now, just make a quick check before.

El nov 15, 2013 8:59 a.m., "Richard Schwarting" <richard schwarting ca> escribió:

Hi Daniel.

Did you ever end up going over my comments from August 15th?
https://mail.gnome.org/archives/gxml-list/2013-August/msg00010.html

I know that on August 19th you responded (https://mail.gnome.org/archives/gxml-list/2013-August/msg00015.html) to my August 7th e-mail.

I asked on August 24th (https://mail.gnome.org/archives/gxml-list/2013-August/msg00020.html) whether you missed the e-mail from the 15th (above) but I haven't seen a reply yet.

If you don't want to go over the August 15th questions/concerns because they might not be out of date, I can do a new review this weekend.  If you can respond to even the August 15th review, then perhaps we can start merging this weekend.