Re: [PATCH] fuse: Make created files visible immediately
- From: Hans Petter Jansson <hpj novell com>
- To: Stefan Hajnoczi <stefanha gmail com>
- Cc: gvfs-list gnome org, Benjamin Otte <otte redhat com>
- Subject: Re: [PATCH] fuse: Make created files visible immediately
- Date: Fri, 25 Mar 2011 02:29:07 +0100
On Wed, 2011-03-23 at 19:51 +0100, Hans Petter Jansson wrote:
> On Wed, 2011-03-16 at 19:02 +0000, Stefan Hajnoczi wrote:
> > This patch changes .vfs_create() to force file creation and then opens
> > the file again for replacement. This ensures that the created file is
> > visible before its file handle is released.
> Thanks for the patch! It looks good to me - i.e. it doesn't obviously
> cause any problems. I've signed off and committed it to the master
> branch.
After a brief discussion with tbzatek on IRC, I've replaced your
approach with one that doesn't require opening the file twice; we now
check if we have an open file handle for the file and if we do, fall
back to faking its existence. The changes are on the master branch.
Please let me know if it still solves your problem.
I've also created a gnome-3-0 branch that does not include these
changes, to avoid breaking code freeze.
--
Hans Petter
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]