[PATCH 3/8] Disable usage of "EPSV ALL".



- works around problem with iPhone DataCase ftp server (bug #547855).
- makes it possible to fall back on PASV when EPSV connection fails.

There probably aren't that many NAT devices that actually takes
advantage of the EPSV ALL feature anyway....
---
 daemon/gvfsbackendftp.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/daemon/gvfsbackendftp.c b/daemon/gvfsbackendftp.c
index 6c50772..109b776 100644
--- a/daemon/gvfsbackendftp.c
+++ b/daemon/gvfsbackendftp.c
@@ -760,9 +760,16 @@ ftp_connection_use (FtpConnection *conn)
     ftp_connection_send (conn, 0, "OPTS UTF8 ON");
 
   /* RFC 2428 suggests to send this to make NAT routers happy */
+#if 0
+  /* XXX: Disabled because of broken ftp servers which can't
+   * see the difference between "EPSV" and "EPSV ALL", plus
+   * making it possible to fall back on regular PASV in case
+   * EPSV doesn't work for some reason.
+   */
   if (conn->features & FTP_FEATURE_EPSV)
     ftp_connection_send (conn, 0, "EPSV ALL");
   g_clear_error (&conn->error);
+#endif
 
   if (ftp_connection_send (conn, 0, "SYST"))
     ftp_connection_parse_system (conn);
-- 
1.5.6.5



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]