Re: [patch] out-of-process volume monitor

[David Zeuthen <david fubar dk>]

On Mon, 2008-07-07 at 15:33 -0400, Matthias Clasen wrote:
> On Mon, Jul 7, 2008 at 3:02 PM, David Zeuthen <david fubar dk> wrote:
> > Hey,
> >
> > In http://bugzilla.gnome.org/show_bug.cgi?id=520132 I've uploaded a
> > patch that
> >
> >  a) implements infrastructure for implementing out-of-process
> >    volume monitors; and
> >
> >  b) port the hal volume monitor to use this
> >
> > OK to apply? The patch is somewhat big (145k) but I've tested it and it
> > seems to work perfectly.
> 
> I'll have a look over the patch later tonight. 

Great thanks. There's some very minor bustage (as pointed out in comment
4) that shouldn't interfere with review efforts. I'll fix that later
tonight.

> For now just a naming question:
> whats 'remote' about the hal or gphoto volume monitors ? Should we just
> make that /usr/share/gvfs/volume-monitors/* instead of
> /usr/share/gvfs/remote-volume-monitors/*
> and [VolumeMonitor] instead of [RemoteVolumeMonitor] ?

Well, it's remote compared to the process using it. I thought about
using OutOfProcessVolumeMonitor resp. out-of-process-volume-monitor but
that seemed a bit long. And I didn't want to go into abbreviations
either ;-)

It might be confusing to just use VolumeMonitor and volume-monitor.

What's in a name anyway? ;-)

      David