Bug in gnome-guile on CVS

[Jon Trowbridge <trow emccta com>]

On Mon, Jan 24, 2000 at 01:12:38PM -0800, Conrad Steenberg wrote:
> On Mon, 24 Jan 2000, Jon Trowbridge wrote:
> > I just tried building the latest gnome-guile out of CVS, and (besides
> > a few warnings) it built cleanly on my box (x86/Debian).  If you
> > e-mail me the details of your failed build, maybe we can figure it
> > out.
> 
> Hi Jon
> 
> The build fails in guile-gnome/gnorba-glue.c. My setup is a bit weird, but
> I don't think that's the problem here:
> Linux/Alpha on an LX164
> Redhat 6.0 upgraded to gnome-1.0.53, gcc-2.95.2, binutils-2.9.1.0.25.


> gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I./.. -I../guile-gtk -I./../guile-gtk -I/usr/include -I/usr/include -I/usr/include -DNEED_GNOMESUPPORT_H -I/usr/lib/gnome-libs/include -I/usr/lib/glib/include -I/usr/X11R6/include -g -O2 -Wp,-MD,.deps/gnorba-glue.pp -c gnorba-glue.c  -fPIC -DPIC -o .libs/gnorba-glue.lo
> gnorba-glue.c:44: warning: initialization makes integer from pointer without a cast
> gnorba-glue.c:44: initializer element is not computable at load time
> gnorba-glue.c:44: (near initialization for `sgtk_corba_orb_info_gtk.object_size')
<many more examples omitted>

This is where I got warnings, but the compile didn't fail.
Looking at gnorba-glue.c, it is full of stuff like this:

GtkTypeInfo sgtk_corba_orb_info_gtk = {
  "CORBAORB", "sizeof (CORBA_ORB)", 0,
  (GtkClassInitFunc) NULL,
  (GtkObjectInitFunc) NULL,
  (GtkArgSetFunc) NULL,
  (GtkArgGetFunc) NULL,
  (GtkClassInitFunc) NULL,
};

Notice how the sizeof(CORBA_ORB) is in quotes, so instead of being a
size_t, it is a char*.  This slips by with a warning on 32-bit
systems, but doesn't fly with 64 bits.

gnorba-glue.c is an auto-generated, so this error probably occurs
in other file as well.  The auto-generator is a fairly complicated
scheme program, but I think I have a fix:

In line 449 of gnome-guile/guile-gtk/build-guile-gtk, change
   (@ "  ~s, ~s, 0,~%"
to
   (@ "  ~s, ~a, 0,~%"

(I guess I could make a patch, but for a 1-character, that seems
excessive.)

This causes the structs to contain sizeof(Foo) rather than
"sizeof(Foo)".

(I've cc:ed this e-mail to Marius Volmer, gnome-guile's author.)

-JT

-- 
COMINT secret | Jam Echelon! http://www.echelon.wiretapped.net | NSA explosives
assassin terrorist car bomb tactical bin laden waco white house nuclear clinton