Re: [PATCH] Fix removal of variable change notifications

From: Jens Georg <mail jensge org>
To: Sven Neumann <s neumann raumfeld com>
Cc: gupnp-list gnome org
Subject: Re: [PATCH] Fix removal of variable change notifications
Date: Fri, 07 Dec 2012 14:59:03 +0100

On Fr, 2012-12-07 at 11:59 +0100, Sven Neumann wrote:
> Need to pass the key to g_hash_table_remove(), not the
> value. This fixes crashes in emit_notification().

Are you sure about the crashes? If I see it correctly, this only leaves
an entry in the hash table, causing a lot more notifications to be
called than necessary, but the only place that ever clears the data is
the remove notify in the hash table, so I'm wondering how
emit_notification can possibly crash.

References:
- [PATCH] Fix removal of variable change notifications
  - From: Sven Neumann

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]