Re: [PATCH 2/2] Send alive/byebye announcements three times.

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

On Thu, Jun 16, 2011 at 9:36 PM, Sven Neumann <s neumann raumfeld com> wrote:
> Well, it might be more complex, but it has been out in the wild on our
> devices for more than a year now.

  I didn't challenge the fact that it works, I'm only worried about
complicating the code unless it gives us some real gain. We also need
to care about not spamming the network and waking-up the CPU.

> The UPnP spec recommends that UPnP devices send a total of 2 or three
> advertisement sets within a 10 second transmission window. That doesn't
> absolutely imply that there should be a delay between the transmissions.
> But if you just send three advertisements directly one after another,
> you do not improve reliability significantly. There needs to be a delay
> so that you end up in a different time slot on your wireless network.

  I really don't think we can agree on what is 'enough reliability'
but Jens' change combined with the fact that we repeat this process at
random intervals 3 times within max-age (30mins by default) sounds
reliable enough to me.

> If you really want to improve reliability, then you should prefer the
> slightly more complex approach.

  Lets see if we get reports of discovery issues due to packet-loss
still and applying your changes will be the first thing we do if/when
that happens.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124