Re: [PATCH 2/2] Send alive/byebye announcements three times.

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

On Thu, Jun 16, 2011 at 7:45 PM, Sven Neumann <s neumann raumfeld com> wrote:
> On Wed, 2011-06-15 at 12:39 +0200, Jens Georg wrote:
>> On Mi, 2011-06-15 at 09:18 +0200, Sven Neumann wrote:
>> > On Tue, 2011-06-14 at 09:00 +0200, Jens Georg wrote:
>> > > On Di, 2011-06-14 at 08:57 +0200, Jens Georg wrote:
>> > > > UPnP recommends to send the whole batch of announcements more than
>> > > > once "due to the unreliable nature of UDP".
>> > >
>> > > Since I have a really unreliable wireless and do have problems with not
>> > > seeing announcements due to packet loss, I think it's a good thing to
>> > > have.
>> >
>> > We've been using a patch for quite a while that does something similar.
>> > I believe though that it is closer to what the spec suggests as it
>> > actually delays the duplicate advertisement sets a little.
>> >
>> > You will find the patch attached to this mail. Sorry for not suggesting
>> > this change earlier. I totally missed that I never submitted this patch
>> > before.
>>
>> Hm, yes. That is indeed more clever than my version :)
>
> I will revert your change then and apply this patch instead. Is that OK
> with you?

  Please dont! While your patch is cleverer, its also slightly more complex.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124