Re: [gupnp] Patch to fix action response XML

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

On Fri, Feb 18, 2011 at 10:44 AM, Sven Neumann <s neumann raumfeld com> wrote:
> On Fri, 2011-02-18 at 09:09 +0100, Sven Neumann wrote:
>> On Thu, 2011-02-17 at 17:18 +0000, Ross Burton wrote:
>> > On Thu, 2011-02-17 at 17:57 +0100, Sven Neumann wrote:
>> > > The following patch against libgupnp fixes a bug in GUPnPService
>> > > that causes a broken XML document to be returned as response to an
>> > > action.
>> >
>> > Pushed, thanks.
>> >
>> > > I really wonder why this has not been caught by any tests yet...
>> >
>> > Bonus points for a test case that demonstrates the breakage before the
>> > fix? :)
>>
>> Well, the code that failed due to this bug in libgupnp was written for
>> the iPhone, which makes it somewhat difficult to share. But sure, I
>> should have written a test case to be included with libgupnp.
>
> Eeeek, I would better have done that. It seems that my change was wrong.
> It did indeed fix the problem I was seeing on the iPhone App, but it
> breaks things badly for other clients. Obviously I didn't test things
> carefully last night before I submitted the patch.
>
> Looks like the quotes are actually expected to be in the HTTP headers of
> the action invocation. I will have to look at this more closely. For now
> please revert the change, it is definitely not correct. Sorry for the
> inconvenience and I promise I'll make a test case next time...

   Since we've been running DLNA CTT against client and server side
for some years now, I was also wondering how such an issue haven't
been caught so far. :) Reverting your patch..

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com