Re: [Gtranslator-devel] code review

[Ross Golder <ross golder org>]

Hi.

You are correct. I had embedded a couple of #ifdefs in code that already
had those #ifdefs. As you said, this isn't that serious, but it is a bit
messy. The outermost #ifdef is intended to prevent the import/export
(from/to UTF) dialogs from being built/run, as they are now redundant.
With glib2/gtk2 everything is held internally as UTF8 anyway, so we are
in the process of replacing these dialogs with 'import/export' to/from
another encoding.

UTF8_CODE is not defined anywhere, as we do not want to build these
dialogs at all. I would have removed all this stuff from the code
completely, but much of it will probably be useful as examples to work
from when we get round to writing the replacement import/export stuff.

Well spotted though, and the typo has been fixed (locally) :)

--
Ross

On อา., 2003-06-22 at 23:19, Spundun Bhatt wrote:
> On Sun, 2003-06-22 at 15:16, Spundun Bhatt wrote:
> > Hi,
> > 
> > I have just started looking at a code.
> > While I was looking at some of the recent changes, I came across this 2
> > things that I thought might be typos.
> > in dialogs.c around line 225 there is #ifdef UTF8_CODE macro which seems
> > to end around line 330. Iside that block, I see another #ifdef UTF8_CODE
> > block, around line 275. THat might not be very serious but the second
> > thing is more interesting, where around line 325, there ius a #ifdef 
> > UTF_CODE block, that looked like a typo cause I have seen only UTF8_CODE
> > sofar.
> > 
> BTW I forgot to ask, I couldnot find anyplace where you were defining
> the UTF8_CODE macro.... where is that coming from? some future support?
> Spundun
> > I have taken a very casual glance at the code.
> > Hope this helps
> > Spundun
> > 
> > 
> > 
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: INetU
> > Attention Web Developers & Consultants: Become An INetU Hosting Partner.
> > Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
> > INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
> > _______________________________________________
> > Gtranslator-devel mailing list
> > Gtranslator-devel lists sourceforge net
> > https://lists.sourceforge.net/lists/listinfo/gtranslator-devel
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: INetU
> Attention Web Developers & Consultants: Become An INetU Hosting Partner.
> Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
> INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
> _______________________________________________
> Gtranslator-devel mailing list
> Gtranslator-devel lists sourceforge net
> https://lists.sourceforge.net/lists/listinfo/gtranslator-devel